Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simple descriptions for file API responses #4089

Merged
merged 3 commits into from
Jun 1, 2018

Conversation

stevegt
Copy link
Contributor

@stevegt stevegt commented May 30, 2018

Swagger needs a description field in each swagger:operation response. Adding
minimal text for now on the way to getting swagger validate to pass. Many
standard swagger client libraries will not work with gitea until validate
passes, so prioritizing that over better descriptions for now.

Signed-off-by: Steve Traugott stevegt@t7a.org

* Partial fix for go-gitea#4010

Swagger needs a description field in each swagger:operation response.  Adding
minimal text for now on the way to getting swagger validate to pass.  Many
standard swagger client libraries will not work with gitea until validate
passes, so prioritizing that over better descriptions for now.

Signed-off-by: Steve Traugott <stevegt@t7a.org>
@codecov-io
Copy link

codecov-io commented May 30, 2018

Codecov Report

Merging #4089 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4089      +/-   ##
==========================================
- Coverage   19.97%   19.97%   -0.01%     
==========================================
  Files         153      153              
  Lines       30491    30494       +3     
==========================================
  Hits         6091     6091              
- Misses      23486    23489       +3     
  Partials      914      914
Impacted Files Coverage Δ
routers/api/v1/repo/file.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7707ad7...3a0e0ab. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 30, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 30, 2018
@lafriks lafriks added type/docs This PR mainly updates/creates documentation modifies/api This PR adds API routes or modifies them labels May 31, 2018
@lafriks lafriks added this to the 1.5.0 milestone May 31, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 31, 2018
@lunny lunny merged commit 39f2aa7 into go-gitea:master Jun 1, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants