add simple descriptions for swagger validate #4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Partial fix for go-gitea#4010 Swagger needs a comment line above each swagger:response comment -- it uses these to populate the description: fields. Adding minimal text for now on the way to getting swagger validate to pass. Many standard swagger client libraries will not work at all with gitea until validate passes, so prioritizing that over better descriptions for now. Signed-off-by: Steve Traugott <stevegt@t7a.org>
Codecov Report
@@ Coverage Diff @@
## master #4087 +/- ##
=======================================
Coverage 19.97% 19.97%
=======================================
Files 153 153
Lines 30491 30491
=======================================
Hits 6091 6091
Misses 23486 23486
Partials 914 914Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
sapk
approved these changes
May 30, 2018
bkcsoft
added
lgtm/need 1
lafriks
approved these changes
May 31, 2018
bkcsoft
added
lgtm/done
lafriks
added
type/docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger needs a comment line above each swagger:response comment -- it
uses these to populate the description: fields. Adding minimal text
for now on the way to getting swagger validate to pass. Many standard
swagger client libraries will not work with gitea until validate passes,
so prioritizing that over better descriptions for now.
Signed-off-by: Steve Traugott stevegt@t7a.org