Skip to content

fix webhook bug of response info is not displayed in UI #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2018
Merged

fix webhook bug of response info is not displayed in UI #4000

merged 4 commits into from
May 23, 2018

Conversation

@lunny
Copy link
Member

@lunny lunny commented May 21, 2018

Will fix #3965

@lunny lunny added the type/bug label May 21, 2018
@lunny lunny added this to the 1.5.0 milestone May 21, 2018
@codecov-io
Copy link

codecov-io commented May 21, 2018 •
edited
Loading

Codecov Report

Merging #4000 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4000      +/-   ##
==========================================
- Coverage   20.05%   20.05%   -0.01%     
==========================================
  Files         153      153              
  Lines       30344    30347       +3     
==========================================
  Hits         6086     6086              
- Misses      23345    23348       +3     
  Partials      913      913
Impacted Files Coverage Δ
models/webhook.go 50.25% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2f0c57...7414b18. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 21, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 21, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 23, 2018
@lunny
Copy link
Member Author

lunny commented May 23, 2018

make L-G-T-M work

@lunny lunny merged commit 4ec8551 into go-gitea:master May 23, 2018
@lunny lunny deleted the lunny/fix_webhook_resp_bug branch May 23, 2018 06:12
@lunny lunny mentioned this pull request May 23, 2018
Merged
@lunny lunny added the backport/done All backports for this PR have been created label May 23, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

Webhook responses are not displayed in the webhook history

5 participants

@lunny @codecov-io @appleboy @lafriks @bkcsoft