Skip to content

add missing token validation and missing alert in UI #3976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2018
Merged

add missing token validation and missing alert in UI #3976

merged 2 commits into from
May 16, 2018

Conversation

@daviian
Copy link
Member

@daviian daviian commented May 16, 2018

As title.

Should be backported to release/v1.4

@codecov-io
Copy link

codecov-io commented May 16, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@d79829f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3976   +/-   ##
=========================================
  Coverage          ?   20.08%           
=========================================
  Files             ?      146           
  Lines             ?    29867           
  Branches          ?        0           
=========================================
  Hits              ?     6000           
  Misses            ?    22961           
  Partials          ?      906

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d79829f...298cbcc. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 16, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 16, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 16, 2018
@lunny lunny added this to the 1.5.0 milestone May 16, 2018
@lunny lunny added topic/ui Change the appearance of the Gitea UI backport/v1.4 labels May 16, 2018
@lunny lunny merged commit 80d1998 into go-gitea:master May 16, 2018
@lunny
Copy link
Member

lunny commented May 16, 2018

@daviian please send back port to release/v1.4

@daviian daviian deleted the bugfix/missing-token-name-validation branch May 16, 2018 14:21
daviian added a commit to daviian/gitea that referenced this pull request May 16, 2018
@daviian
add missing token validation on application settings page (go-gitea#3976
c1b4d64 
)
@daviian daviian mentioned this pull request May 16, 2018
Merged
lunny pushed a commit that referenced this pull request May 16, 2018
@daviian @lunny
add missing token validation on application settings page (#3976) (#3978
5f169bf 
)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@jonasfranz jonasfranz jonasfranz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

6 participants

@daviian @codecov-io @lunny @lafriks @jonasfranz @bkcsoft