Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TRANSLATORS #3933

Merged
merged 5 commits into from May 19, 2018
Merged

Update TRANSLATORS #3933

merged 5 commits into from May 19, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 9, 2018

No description provided.

lafriks
lafriks requested changes May 9, 2018
View reviewed changes
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move your name to correct position in list, it is in alphabetical order

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 9, 2018
@codecov-io
Copy link

codecov-io commented May 9, 2018 •
edited
Loading

Codecov Report

Merging #3933 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3933   +/-   ##
=======================================
  Coverage   20.06%   20.06%           
=======================================
  Files         153      153           
  Lines       30122    30122           
=======================================
  Hits         6044     6044           
  Misses      23168    23168           
  Partials      910      910

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01835a4...e39de02. Read the comment docs.

@ghost
Copy link
Author

ghost commented May 9, 2018

@lafriks hmm is this better? i just updated it.

ghost
ghost commented May 9, 2018
View reviewed changes
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that is what you meant sorry that i wasted your time.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 10, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2018
@lunny
Copy link
Member

lunny commented May 11, 2018

@lafriks need your approval.

@techknowlogick
Copy link
Member

@lafriks pending your approval

@lunny lunny merged commit c7a4317 into go-gitea:master May 19, 2018
@ghost ghost deleted the patch-1 branch May 20, 2018 13:22
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@codecov-io @lunny @techknowlogick @appleboy @lafriks @jonasfranz @bkcsoft @rthotbelow