Skip to content

Don't force due date to current time #3830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2018
Merged

Don't force due date to current time #3830

merged 1 commit into from
Apr 23, 2018

Conversation

@thehowl
Copy link
Contributor

@thehowl thehowl commented Apr 22, 2018

Fixes #3827

@codecov-io
Copy link

Codecov Report

Merging #3830 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3830      +/-   ##
=========================================
- Coverage   23.02%     23%   -0.02%     
=========================================
  Files         126     126              
  Lines       24894   24892       -2     
=========================================
- Hits         5731    5726       -5     
- Misses      18287   18289       +2     
- Partials      876     877       +1
Impacted Files Coverage Δ
models/issue_milestone.go 56.17% <ø> (-0.37%) ⬇️
modules/process/manager.go 69.56% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae2642...b15fd92. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 22, 2018
@lafriks lafriks added this to the 1.5.0 milestone Apr 22, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 22, 2018
@lunny
Copy link
Member

lunny commented Apr 23, 2018

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 23, 2018
@lunny lunny merged commit 320c981 into go-gitea:master Apr 23, 2018
@lunny
Copy link
Member

lunny commented May 18, 2018

@thehowl please backport to v1.4

@lunny
Copy link
Member

lunny commented May 18, 2018

see https://twitter.com/rovillablanca/status/997185995043954688

lafriks pushed a commit that referenced this pull request May 27, 2018
@thehowl @lafriks
Don't force due date to current time (#3830) (#4057)
dec663c
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

Saving new milestone ignores due date

5 participants

@thehowl @codecov-io @lunny @lafriks @bkcsoft