Skip to content

Use correct form field for allowed force push users in branch protection API #35894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use correct form field for allowed force push users in branch protection API #35894

wants to merge 1 commit into from
+1 −1

Conversation

@zorrobiwan
Copy link

@zorrobiwan zorrobiwan commented Nov 7, 2025

Test was wrong and preventing update of force push allow users list by the API

Resolves #35893

@zorrobiwan
Change ForcePushAllowlistDeployKeys to forcePushAllowlistUsers
b9376b2 
Test was wrong and preventing update of force push allow users list by the API

Signed-off-by: Alberty Pascal <github@albertyorban.be>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 7, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 7, 2025
@zorrobiwan zorrobiwan changed the title Change ForcePushAllowlistDeployKeys to forcePushAllowlistUsers Change ForcePushAllowlistDeployKeys to forcePushAllowlistUsers in test to allow force push allowlist users to be modified by API Nov 7, 2025
@zorrobiwan zorrobiwan mentioned this pull request Nov 7, 2025
Open
@lunny
Copy link
Member

lunny commented Nov 7, 2025

Thank you for the contribution. It's better to have a test for that.

@delvh delvh changed the title Change ForcePushAllowlistDeployKeys to forcePushAllowlistUsers in test to allow force push allowlist users to be modified by API Use correct form field for allowed force push users in API Nov 8, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 8, 2025
@delvh delvh changed the title Use correct form field for allowed force push users in API Use correct form field for allowed force push users in branch protection API Nov 8, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delvh delvh delvh approved these changes

+1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Force Push Allowlist users can't be updated by API

5 participants

@zorrobiwan @lunny @Zettat123 @delvh @GiteaBot