Skip to content

Fix avatar upload error handling #35887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2025
Merged

Fix avatar upload error handling #35887

merged 2 commits into from
Nov 7, 2025
+8 −10

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 6, 2025

Fix #35884

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 6, 2025
@wxiaoguang wxiaoguang mentioned this pull request Nov 6, 2025
Closed
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 6, 2025
@wxiaoguang wxiaoguang added type/bug backport/v1.25 and removed modifies/go Pull requests that update Go code labels Nov 6, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 6, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 6, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 6, 2025
delvh
delvh approved these changes Nov 6, 2025
View reviewed changes
services/auth/source/ldap/source_authenticate.go
if err := user_service.UploadAvatar(ctx, user, sr.Avatar); err != nil {
return user, err
}
_ = user_service.UploadAvatar(ctx, user, sr.Avatar)
Copy link
Member

@delvh delvh Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we log the error?

Copy link
Contributor Author

@wxiaoguang wxiaoguang Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see the necessity:

image

@wxiaoguang wxiaoguang merged commit 0ce7d66 into go-gitea:main Nov 7, 2025
25 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Nov 7, 2025
@GiteaBot
Copy link
Collaborator

GiteaBot commented Nov 7, 2025

I was unable to create a backport for 1.25. @wxiaoguang, please send one manually. 🍵

go run ./contrib/backport 35887
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Nov 7, 2025
@wxiaoguang wxiaoguang deleted the fix-sync-avatar branch November 7, 2025 01:44
@wxiaoguang wxiaoguang mentioned this pull request Nov 7, 2025
Merged
@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Nov 7, 2025
wxiaoguang added a commit that referenced this pull request Nov 7, 2025
@wxiaoguang
Fix avatar upload error handling (#35887) (#35890)
e5b404e 
Backport #35887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

+1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

First login via LDAP fails if there is no avatar

5 participants

@wxiaoguang @GiteaBot @lunny @Zettat123 @delvh