-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Set GOTOOLCHAIN=auto in docker build containers
#35883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
GOTOOLCHAIN=auto in docker build containers
|
BTW I restarted https://github.com/go-gitea/gitea/actions/runs/19129348180/job/54717708169 and it completed successfully now, so the time window where builds fail is pretty narrow, less than 24 hours. But given that this is not the first time this issue has come up, I think it's good to go ahead with this. |
|
It seems that we don't need this change anymore? New builds all succeed ..... no idea about the root reason behind it. |
|
I think the root cause must be some cache issue because there's only a 23 minute gap between go tag and image tag: golang/go@f2cd93a Still it's likely this will become an issue again in the future if we bump quickly enough. |
|
Maybe it's better to leave it at default, but don't complain next time a build fails because of GOTOOLCHAIN after a go version update. |
Agree, I think we can add a comment before the |
|
Alternative: #35901 |
In docker-library/golang#472 it was decided to set
GOTOOLCHAIN=localin these containers which inhibits go from downloading newer toolchains when the current one is older than the one defined ingo.mod.This should fix the nightly build errors from #35877.
From docs: