Skip to content

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Nov 6, 2025

In docker-library/golang#472 it was decided to set GOTOOLCHAIN=local in these containers which inhibits go from downloading newer toolchains when the current one is older than the one defined in go.mod.

This should fix the nightly build errors from #35877.

From docs:

When using GOTOOLCHAIN=auto or GOTOOLCHAIN=+auto, the Go command downloads newer toolchains as needed

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 6, 2025
@silverwind silverwind mentioned this pull request Nov 6, 2025
@silverwind silverwind changed the title Set GOTOOLCHAIN=auto in docker build containers Set GOTOOLCHAIN=auto in docker build containers Nov 6, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 6, 2025
@silverwind
Copy link
Member Author

silverwind commented Nov 6, 2025

BTW I restarted https://github.com/go-gitea/gitea/actions/runs/19129348180/job/54717708169 and it completed successfully now, so the time window where builds fail is pretty narrow, less than 24 hours. But given that this is not the first time this issue has come up, I think it's good to go ahead with this.

@wxiaoguang wxiaoguang marked this pull request as draft November 7, 2025 00:47
@wxiaoguang
Copy link
Contributor

It seems that we don't need this change anymore?

New builds all succeed ..... no idea about the root reason behind it.

@silverwind
Copy link
Member Author

silverwind commented Nov 7, 2025

I think the root cause must be some cache issue because there's only a 23 minute gap between go tag and image tag:

golang/go@f2cd93a
docker-library/golang@63f58b7

Still it's likely this will become an issue again in the future if we bump quickly enough.

@silverwind
Copy link
Member Author

silverwind commented Nov 8, 2025

Maybe it's better to leave it at default, but don't complain next time a build fails because of GOTOOLCHAIN after a go version update.

@silverwind silverwind closed this Nov 8, 2025
@silverwind silverwind deleted the autochain branch November 8, 2025 15:07
@wxiaoguang
Copy link
Contributor

Maybe it's better to leave it at default, but don't complain next time a build fails because of GOTOOLCHAIN after a go version update.

Agree, I think we can add a comment before the go {version} to explain the situation: just wait for a while after a new Go version gets released, then then images will be ready in a short while.

@silverwind
Copy link
Member Author

Alternative: #35901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants