Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if Mirrors repo no content is fetched, updated time should not be changed #3551 #3565

Merged
merged 3 commits into from
Feb 23, 2018
Merged

if Mirrors repo no content is fetched, updated time should not be changed #3551 #3565

merged 3 commits into from
Feb 23, 2018

Conversation

appleboy
Copy link
Member

@appleboy appleboy commented Feb 23, 2018 •
edited
Loading

backport to v1.4 from #3551

cc @lafriks @lunny

@appleboy
refactor: reduce sql query in retrieveFeeds
726748a
@appleboy
fix: if Mirrors repo no content is fetched, updated time should not b… (
a4ad6a9 
go-gitea#3551)

* fix: if Mirrors repo no content is fetched, updated time should not be changed

* fix: sync update time from mirror repo.

* fix: one single session.

* update comment.

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@lunny lunny added this to the 1.4.0 milestone Feb 23, 2018
@sapk
Copy link
Member

sapk commented Feb 23, 2018

It seems you also backport #3554 in this PR.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 23, 2018
sapk
sapk approved these changes Feb 23, 2018
View reviewed changes
Copy link
Member

@sapk sapk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusted LGTM.
You may look at CI fail or restart the build if you think it is un-related.

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 23, 2018
@lunny
Copy link
Member

lunny commented Feb 23, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 23, 2018
@lafriks lafriks merged commit e55eaa8 into go-gitea:release/v1.4 Feb 23, 2018
@appleboy appleboy deleted the release/v1.4.2 branch February 23, 2018 14:03
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk approved these changes

@lafriks lafriks lafriks approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@appleboy @sapk @lunny @lafriks @tboerger