Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API endpoint for testing webhook #3550

Merged
merged 4 commits into from
Apr 29, 2018
Merged

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Feb 21, 2018

Adds a POST /repos/:owner/:repo/hooks/:id/tests API endpoint for testing a push webhook. Also adds a unit test for the endpoint.

@codecov-io
Copy link

codecov-io commented Feb 21, 2018

Codecov Report

Merging #3550 into master will decrease coverage by 3.06%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3550      +/-   ##
==========================================
- Coverage   23.29%   20.23%   -3.07%     
==========================================
  Files         126      145      +19     
  Lines       25002    28997    +3995     
==========================================
+ Hits         5825     5867      +42     
- Misses      18289    22240    +3951     
- Partials      888      890       +2
Impacted Files Coverage Δ
routers/api/v1/repo/hook.go 19.11% <76.47%> (ø)
routers/api/v1/repo/issue_comment.go 0% <0%> (ø)
routers/api/v1/repo/issue_label.go 0% <0%> (ø)
routers/api/v1/repo/fork.go 0% <0%> (ø)
routers/api/v1/repo/milestone.go 0% <0%> (ø)
routers/api/v1/repo/release.go 0% <0%> (ø)
routers/api/v1/repo/issue.go 0% <0%> (ø)
routers/api/v1/repo/release_attachment.go 0% <0%> (ø)
routers/api/v1/repo/file.go 0% <0%> (ø)
routers/api/v1/repo/branch.go 0% <0%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a62eb3...88fcb38. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 21, 2018
@lunny lunny added the modifies/api This PR adds API routes or modifies them label Feb 26, 2018
@lunny lunny added this to the 1.5.0 milestone Feb 26, 2018
@lunny
Copy link
Member

lunny commented Feb 26, 2018

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 26, 2018
@tboerger tboerger removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 25, 2018
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Mar 25, 2018
@lunny
Copy link
Member

lunny commented Mar 29, 2018

conflict

@ethantkoenig
Copy link
Member Author

@lunny conflict fixed

@lunny lunny merged commit 7ea4bfc into go-gitea:master Apr 29, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants