Skip to content

Fix incorrect comment diff hunk parsing, fix github asset ID nil panic (#35046) #35055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2025
Merged

Fix incorrect comment diff hunk parsing, fix github asset ID nil panic (#35046) #35055

merged 2 commits into from
Jul 12, 2025

Conversation

@GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Jul 12, 2025 •
edited by wxiaoguang
Loading

@lunny @wxiaoguang @GiteaBot
Fix incorrect comment diff hunk parsing, fix github asset ID nil panic (
322a05e 
go-gitea#35046)

* Fix missing the first char when parsing diff hunk header
* Fix go-gitea#35040
* Fix go-gitea#35049

----

Introduced in
https://github.com/go-gitea/gitea/pull/12047/files#diff-de48c2f70e24ff5603180acf8b5ce9d0356ede8a45bfbf2a485707282ace6d6aR268

Before:

<img width="487" height="167" alt="image"
src="https://github.com/user-attachments/assets/17524c76-a296-4b4b-a4f9-c5150c41bae5"
/>

After:

<img width="749" height="144" alt="image"
src="https://github.com/user-attachments/assets/bcb12c76-c1ae-40f1-81b7-183d15f891db"
/>

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code type/bug labels Jul 12, 2025
@GiteaBot GiteaBot added this to the 1.24.3 milestone Jul 12, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 12, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 12, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 12, 2025
@wxiaoguang wxiaoguang merged commit dd661e9 into go-gitea:release/v1.24 Jul 12, 2025
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind Awaiting requested review from silverwind

Assignees

@lunny lunny

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

1.24.3

Development

Successfully merging this pull request may close these issues.

3 participants

@GiteaBot @lunny @wxiaoguang