Fix bug when displaying git user avatar in commits list #35003
Conversation
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
the
modifies/templates
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
I don't think this has any relation to #34991. The missing user association happens in both commit list and PR commit history. It is fine in single commit view and latest commit. I think a more fundamental fix will be needed. |
A quick fix for go-gitea#34991 `ValidateCommitsWithEmails` will create a fake user for a git commit user with a related Gitea user. The UI should not display a link for such users.
GiteaBot
added
backport/done
|
I don't the fix is right. The old logic doesn't set And please add a test |
It is related but this fix is not the one supposed to be. See #35003 (comment) |
* giteaofficial/main: Refactor mail template and support preview (go-gitea#34990) [skip ci] Updated translations via Crowdin Fix bug when displaying git user avatar in commits list (go-gitea#35003) Tweak placement of diff file menu (go-gitea#34999) Start automerge check again after the conflict check and the schedule (go-gitea#34989) Refactor time tracker UI (go-gitea#34983) [skip ci] Updated translations via Crowdin Improve NuGet API Parity (go-gitea#21291) (go-gitea#34940)
|
Please review the proper fix: Fix git commit committer parsing and add some tests #35007 |
|
Definitely not a right fix, the issues seen in #34991 affect multiple places in the UI and changing only one non-shared place in the template won't fix it properly. |
|
This was obviously never tested, because otherwise the incorrectly formatted HTML comment would have been noticed: 
|
|
Hmm ... fortunately we have a proper fix now. And since the proper fix is quite large, I would suggest either use a quick patch for 1.24 (only check ID!=0), or just don't backport. I guess end users could bear it, not a serious bug in most cases, just a 404 page. We can release 1.25 soon if we'd like to land more fixes, actually 1.25 contains many important fixes including the container bug, which can't be backported to 1.24 |
|
Yes, I agree that a 404 link is a acceptable flaw. I think we need more rigorous integration tests to avoid bugs like this in the future. |
A quick fix for go-gitea#34991 `ValidateCommitsWithEmails` will create a fake user for a git commit user with a related Gitea user. The UI should not display a link for such users.
A quick fix for #34991
ValidateCommitsWithEmailswill create a fake user for a git commit user with a related Gitea user. The UI should not display a link for such users.