Skip to content

Fix git graph page #34948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 4, 2025
Merged

Fix git graph page #34948

merged 4 commits into from
Jul 4, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jul 4, 2025 •
edited
Loading

Too many bugs, fix together

And fix #34946

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 4, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/frontend labels Jul 4, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jul 4, 2025 •
edited
Loading

Before:

image

After:

image

And there is a regression from "Remove jQuery from the commit graph (except Fomantic) (#30395)", the "hover highlight" stopped working since that time. Actually no one noticed it, no user ever complained, and the "visual feedback" is not obvious. So this PR removes that part of code.

@wxiaoguang wxiaoguang mentioned this pull request Jul 4, 2025
Closed
@wxiaoguang wxiaoguang added type/bug backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! labels Jul 4, 2025
silverwind
silverwind reviewed Jul 4, 2025
View reviewed changes
silverwind
silverwind reviewed Jul 4, 2025
View reviewed changes
silverwind
silverwind requested changes Jul 4, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 4, 2025
@silverwind silverwind self-requested a review July 4, 2025 11:49
@silverwind silverwind removed the lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged label Jul 4, 2025
@GiteaBot GiteaBot added the lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged label Jul 4, 2025
@silverwind
Update web_src/js/features/repo-graph.ts
7b70df6 
Signed-off-by: silverwind <me@silverwind.io>
silverwind
silverwind approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, have not tested it.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Jul 4, 2025
delvh
delvh reviewed Jul 4, 2025
View reviewed changes
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jul 4, 2025 •
edited
Loading

@delvh

I don't think the data-tooltip-content is right

image

@delvh
Copy link
Member

delvh commented Jul 4, 2025

Wait, but why are we displaying a title there then in the first place?

@silverwind
Copy link
Member

I'd remove the tooltip entirely there.

@delvh
Copy link
Member

delvh commented Jul 4, 2025

Isn't the title there equally faulty?

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jul 4, 2025 •
edited
Loading

I'd remove the tooltip entirely there.

They have gt-ellipsis, the title is still good to have.

This PR aims to fix a lot of legacy problems, UI re-design is not in this PR's scope.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 4, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) July 4, 2025 15:26
wxiaoguang added a commit that referenced this pull request Jul 4, 2025
@wxiaoguang
Fix git graph page (#34948) (#34949)
4aba425
@wxiaoguang wxiaoguang merged commit 70685a9 into go-gitea:main Jul 4, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Jul 4, 2025
@wxiaoguang wxiaoguang deleted the fix-gitgraph branch July 4, 2025 15:45
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 7, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
71cf5d3 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Rerun job only when run is done (go-gitea#34970)
  Enable gocritic `equalFold` and fix issues (go-gitea#34952)
  Fixed minor typos in two files #HSFDPMUW (go-gitea#34944)
  Improve project & label color picker and image scroll (go-gitea#34971)
  Refactor webhook and fix feishu/lark secret (go-gitea#34961)
  Improve OAuth2 provider (correct Issuer, respect ENABLED) (go-gitea#34966)
  Merge index.js (go-gitea#34963)
  [skip ci] Updated translations via Crowdin
  Mark old reviews as stale on agit pr updates (go-gitea#34933)
  Refactor "delete-button" to "link-action" (go-gitea#34962)
  Refactor frontend unique id & comment (go-gitea#34958)
  Refactor some trivial problems (go-gitea#34959)
  Upgrade security public key (go-gitea#34956)
  Fix git graph page (go-gitea#34948)
  Update JS dependencies (go-gitea#34951)
  Refactor head navbar icons (go-gitea#34922)

# Conflicts:
#	templates/base/head_navbar.tmpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/bug
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

Commit Graph - Paging broken when any branch is selected
4 participants
@wxiaoguang @delvh @silverwind @GiteaBot