Use unique temp dirs in unit tests #3494
Conversation
ethantkoenig
force-pushed
the
fix/unit_tests
branch
from
ba64451
to
1d6a27f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3494 +/- ##
==========================================
- Coverage 35.74% 35.72% -0.02%
==========================================
Files 284 284
Lines 40778 40792 +14
==========================================
- Hits 14576 14574 -2
- Misses 24041 24054 +13
- Partials 2161 2164 +3
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
|
Does integration tests also reuse these directories? |
|
@lafriks No |
|
But we don't run tests in parallel I think |
|
@lafriks I know, but
|
|
@ethantkoenig problem with this is that these directories will be left undeleted I think |
|
@lafriks Good point, fixed |
|
@ethantkoenig as for 2nd point - To me it looks like something keeps running in background that uses repos and that's why there is problem that they can't be deleted for next test... I spend 5 hours on weekend trying to pinpoint where but with no success :( |
models/unit_tests.go
Outdated
| os.Exit(m.Run()) | ||
| exitStatus := m.Run() | ||
| if err = os.RemoveAll(setting.RepoRootPath); err != nil { | ||
| fatalTestError("os.RemoveAll: %v\n", err) |
There was a problem hiding this comment.
why not just use assert.NoError(t, err)?
There was a problem hiding this comment.
There is no t variable
models/unit_tests.go
Outdated
| } | ||
|
|
||
| os.Exit(m.Run()) | ||
| exitStatus := m.Run() | ||
| if err = os.RemoveAll(setting.RepoRootPath); err != nil { |
There was a problem hiding this comment.
Please use removeAllWithRetry func
ethantkoenig
force-pushed
the
fix/unit_tests
branch
from
6001566
to
1f1b6eb
Compare
tboerger
added
lgtm/need 1
tboerger
added
lgtm/done
| } | ||
|
|
||
| os.Exit(m.Run()) | ||
| exitStatus := m.Run() | ||
| if err = removeAllWithRetry(setting.RepoRootPath); err != nil { |
There was a problem hiding this comment.
These should be defered. Not done at the end
Using a fixed directory causes problems if you run tests in parallel.
Using a fixed directory may have also caused tests to be flaky (e.g. https://drone.gitea.io/go-gitea/gitea/3530/8).