-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Add GitHub API compatibility for workflow runs filtering #34894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bdruth
wants to merge
5
commits into
go-gitea:main
Choose a base branch
from
bdruth:feature/enhanced-workflow-runs-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+651
−9
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
18546ed
Add GitHub API compatibility for workflow runs filtering
bdruth aeaa2c1
Update Swagger documentation for workflow runs API
bdruth 722ac05
run `make fmt`
bdruth 695496c
Apply Go modernization fixes - use strings.CutPrefix instead of HasPr…
bdruth 8b7ed3a
Address PR review feedback for workflow runs API
bdruth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,104 @@ | ||
// Copyright 2025 The Gitea Authors. All rights reserved. | ||
// SPDX-License-Identifier: MIT | ||
|
||
package actions | ||
|
||
import ( | ||
"testing" | ||
"time" | ||
|
||
"code.gitea.io/gitea/modules/webhook" | ||
|
||
"github.com/stretchr/testify/assert" | ||
"xorm.io/builder" | ||
) | ||
|
||
func TestFindRunOptions_ToConds_ExcludePullRequests(t *testing.T) { | ||
// Test when ExcludePullRequests is true | ||
opts := FindRunOptions{ | ||
ExcludePullRequests: true, | ||
} | ||
cond := opts.ToConds() | ||
|
||
// Convert the condition to SQL for assertion | ||
sql, args, err := builder.ToSQL(cond) | ||
assert.NoError(t, err) | ||
// The condition should contain the trigger_event not equal to pull_request | ||
assert.Contains(t, sql, "`action_run`.trigger_event<>") | ||
assert.Contains(t, args, webhook.HookEventPullRequest) | ||
} | ||
|
||
func TestFindRunOptions_ToConds_CheckSuiteID(t *testing.T) { | ||
// Test when CheckSuiteID is set | ||
const testSuiteID int64 = 12345 | ||
opts := FindRunOptions{ | ||
CheckSuiteID: testSuiteID, | ||
} | ||
cond := opts.ToConds() | ||
|
||
// Convert the condition to SQL for assertion | ||
sql, args, err := builder.ToSQL(cond) | ||
assert.NoError(t, err) | ||
// The condition should contain the check_suite_id equal to the test value | ||
assert.Contains(t, sql, "`action_run`.check_suite_id=") | ||
assert.Contains(t, args, testSuiteID) | ||
} | ||
|
||
func TestFindRunOptions_ToConds_CreatedDateRange(t *testing.T) { | ||
// Test when CreatedAfter and CreatedBefore are set | ||
startDate := time.Date(2023, 1, 1, 0, 0, 0, 0, time.UTC) | ||
endDate := time.Date(2023, 12, 31, 23, 59, 59, 0, time.UTC) | ||
|
||
opts := FindRunOptions{ | ||
CreatedAfter: startDate, | ||
CreatedBefore: endDate, | ||
} | ||
cond := opts.ToConds() | ||
|
||
// Convert the condition to SQL for assertion | ||
sql, args, err := builder.ToSQL(cond) | ||
assert.NoError(t, err) | ||
// The condition should contain created >= startDate and created <= endDate | ||
assert.Contains(t, sql, "`action_run`.created>=") | ||
assert.Contains(t, sql, "`action_run`.created<=") | ||
assert.Contains(t, args, startDate) | ||
assert.Contains(t, args, endDate) | ||
} | ||
|
||
func TestFindRunOptions_ToConds_CreatedAfterOnly(t *testing.T) { | ||
// Test when only CreatedAfter is set | ||
startDate := time.Date(2023, 1, 1, 0, 0, 0, 0, time.UTC) | ||
|
||
opts := FindRunOptions{ | ||
CreatedAfter: startDate, | ||
} | ||
cond := opts.ToConds() | ||
|
||
// Convert the condition to SQL for assertion | ||
sql, args, err := builder.ToSQL(cond) | ||
assert.NoError(t, err) | ||
// The condition should contain created >= startDate | ||
assert.Contains(t, sql, "`action_run`.created>=") | ||
assert.Contains(t, args, startDate) | ||
// But should not contain created <= endDate | ||
assert.NotContains(t, sql, "`action_run`.created<=") | ||
} | ||
|
||
func TestFindRunOptions_ToConds_CreatedBeforeOnly(t *testing.T) { | ||
// Test when only CreatedBefore is set | ||
endDate := time.Date(2023, 12, 31, 23, 59, 59, 0, time.UTC) | ||
|
||
opts := FindRunOptions{ | ||
CreatedBefore: endDate, | ||
} | ||
cond := opts.ToConds() | ||
|
||
// Convert the condition to SQL for assertion | ||
sql, args, err := builder.ToSQL(cond) | ||
assert.NoError(t, err) | ||
// The condition should contain created <= endDate | ||
assert.Contains(t, sql, "`action_run`.created<=") | ||
assert.Contains(t, args, endDate) | ||
// But should not contain created >= startDate | ||
assert.NotContains(t, sql, "`action_run`.created>=") | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no such column at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, take that out, that small part of the GitHub API compatibility won't exist, but it's a pretty minor aspect, I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seem that this PR is written by AI, and the non-existing column is caused by AI hallucination?
We need to make sure every line you proposed to change should be fully understood and has a clear meaning, I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear: AI is good, I also use AI. I mean: I think we shouldn't keep the non-existing column in code, we need to leave a clear comment for this case.