Skip to content

Fix incorrect cli default values and default command #34765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2025
Merged

Fix incorrect cli default values and default command #34765

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7cf6ac3
fix
wxiaoguang Jun 18, 2025
c5b7ee4
fix tests
wxiaoguang Jun 18, 2025
50fab97
fix default command
wxiaoguang Jun 18, 2025
2e39ea4
fix lint
wxiaoguang Jun 18, 2025
ec1d686
revert more default "true"
wxiaoguang Jun 18, 2025
3283ca6
fine tune
wxiaoguang Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fine tune
  • Loading branch information
@wxiaoguang
wxiaoguang committed Jun 18, 2025
commit 3283ca6b30972a2ce1c11d294bb9225a836bb990
6 changes: 3 additions & 3 deletions cmd/cmd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func TestDefaultCommand(t *testing.T) {
assert.NoError(t, cmd.Run(t.Context(), args))
assert.True(t, called)
}
test(t, []string{"app"}, "", true)
test(t, []string{"app", "test"}, "", true)
test(t, []string{"app", "other"}, "other", false)
test(t, []string{"./gitea"}, "", true)
test(t, []string{"./gitea", "test"}, "", true)
test(t, []string{"./gitea", "other"}, "other", false)
}