Skip to content

Optimize team member ux #34593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kerwin612
Copy link
Member

image

image

Try to solve #22054

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 3, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/frontend labels Jun 3, 2025
ctx.Data["Page"] = pager
ctx.Data["Teams"] = teams
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH if you have "all teams" here, then the "pager" doesn't make sense any more.

<a class="ui primary button" href="{{.OrgLink}}/teams/new">{{svg "octicon-plus"}} {{ctx.Locale.Tr "org.create_new_team"}}</a>
{{end}}
{{if .IsOrganizationMember}}
<a class="ui primary button" href="{{.OrgLink}}/teams">{{svg "octicon-people"}} {{ctx.Locale.Tr "org.all_teams"}}</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the "all teams" link already in the navbar?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original intention was to provide a more eye-catching entry on the secondary page.

{{if or .IsOrganizationOwner .IsOrganizationMember}}
<div class="flex-text-block tw-justify-end tw-gap-x-1 tw-gap-y-2 tw-mb-4">
{{if .IsOrganizationOwner}}
<a class="ui primary button" href="{{.OrgLink}}/teams/new">{{svg "octicon-plus"}} {{ctx.Locale.Tr "org.create_new_team"}}</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why members list page should show "add new team"? I guess it should show "add new member" instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like above, there is no mistake. It is indeed about adding a new team. My original intention is to provide a more eye-catching and convenient operation entry on the secondary page.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jun 3, 2025

Before making more changes, I think there could be a better design, instead of adding the modal.

The root problem is that "it is not clear about how to add a team member". To make it clear, we can just:

  1. Remove the "View" and "Join" button from the team header on the teams list page, and add a "Add member" button.
  2. Add a prompt message on the "members" page: To add members to this org, please go to Teams page, add the user to a team.

@kerwin612
Copy link
Member Author

Before making more changes, I think there could be a better design, instead of adding the modal.

OK, I'll implement a version according to this train of thought and see the effect.

@jbrubake
Copy link

jbrubake commented Jul 23, 2025

Before making more changes, I think there could be a better design, instead of adding the modal.

The root problem is that "it is not clear about how to add a team member". To make it clear, we can just:

1. Remove the "View" and "Join" button from the team header on the teams list page, and add a "Add member" button.

2. Add a prompt message on the "members" page: To add members to this org, please go to Teams page, add the user to a team.

TBH I don't understand why you wouldn't want the Add Team Member button on the Team Member page. That's where I go every single time I want to add a Team Member because that's why I assume such a button would be

Unless I'm misunderstanding your comment

@wxiaoguang
Copy link
Contributor

TBH I don't understand why you wouldn't want the Add Team Member button on the Team Member page. That's where I go every single time I want to add a Team Member because that's why I assume such a button would be

Unless I'm misunderstanding your comment

"2" is exactly the same as adding a Add Team Member button on the Team Member page, while "2" is more consistent and maintainable. I don't see any fundamental difference.

@jbrubake
Copy link

TBH I don't understand why you wouldn't want the Add Team Member button on the Team Member page. That's where I go every single time I want to add a Team Member because that's why I assume such a button would be
Unless I'm misunderstanding your comment

"2" is exactly the same as adding a Add Team Member button on the Team Member page, while "2" is more consistent and maintainable. I don't see any fundamental difference.

Putting the button on the Team List page and adding a note on the Team member List page that directs you there is definitely not the same thing (apologies if I'm misunderstanding your proposal)

Logically, I go to the Team Member List page to add someone (I do this every time because I can never remember how to actually do it). With your change I'd still do that and then have to go somewhere else to do the actual adding

That's bad interface design--functionality should be intuitive and not require the user who did the intuitive thing to be redirected to a non-intuitive location

@wxiaoguang
Copy link
Contributor

Putting the button on the Team List page and adding a note on the Team member List page that directs you there is definitely not the same thing (apologies if I'm misunderstanding your proposal)

I don't understand why they are different.

  • Put a button:
    • End user clicks the button
    • Navigate to the "add team member" UI or modal dialog
    • Choose a team to add a member
  • Put a prompt message with link (or even button-like link):
    • End user clicks the link
    • Navigate to the "team list" page
    • Choose a team to add a member or add a new team

Actually "Put a button" does worse in this case: what if there is no "team"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants