Skip to content

Enable @typescript-eslint/no-use-before-define #33715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

Enable @typescript-eslint/no-use-before-define #33715

merged 1 commit into from
Feb 25, 2025

Conversation

silverwind
Copy link
Member

The rule is a superset of the eslint base rule, and I tested it with #33514 (comment) where it does not raise an error for cyclic types.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 25, 2025
@silverwind silverwind added topic/code-linting skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 25, 2025
@silverwind silverwind mentioned this pull request Feb 25, 2025
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 25, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 25, 2025
@silverwind
Copy link
Member Author

BTW I see that CI did not trigger compliance / frontend, I think the files-changed list needs some updates, will follow up later. But lint-js was passing locally so should be fine.

@silverwind silverwind merged commit b35a9da into go-gitea:main Feb 25, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Feb 25, 2025
@silverwind silverwind deleted the no-use branch February 25, 2025 15:32
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 26, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
0ba4fb8 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix inconsistent closed issue list icon (go-gitea#33722)
  Update files-changed and labeler globs (go-gitea#33720)
  Enable `@typescript-eslint/no-use-before-define` (go-gitea#33715)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators May 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/code-linting

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

4 participants

@silverwind @wxiaoguang @delvh @GiteaBot