-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the default action for the gitea executable that of running the webserver #3331
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3331 +/- ##
==========================================
- Coverage 35.05% 34.85% -0.21%
==========================================
Files 280 280
Lines 40556 40559 +3
==========================================
- Hits 14216 14135 -81
- Misses 24236 24336 +100
+ Partials 2104 2088 -16
Continue to review full report at Codecov.
|
LGTM although I don't really feel a need for this (but I'm not against if you do) |
This is really a proposal rather than a PR - I'd really love to hear everyone's take on this even just as a +1/-1 on the OP. I think it improves usability by first-timers, of course there is no need for this, it's just a quality-of-life thing :) |
I do better like that it prints help by default but that just my preference |
Yes Please. LGTM 🎉 |
maybe we should update the document. |
Not really in favor but not against and you have at least two LGTM. |
Yes, that is intended. I don't want to create confusion among the users about where the web command flags can be used (e.g. one might think that they also apply to all other subcommands), so unless web is specified no other flags will be accepted. FWIW, this paradigm is also present in git itself: |
@thehowl thanks for the details. |
…ing the webserver (go-gitea#3331)" I don't actually like this feature, since starting the web server with a default config creates a bunch of install files This reverts commit 88a3bb6.
…ing the webserver (go-gitea#3331)" I don't actually like this feature, since starting the web server with a default config creates a bunch of install files This reverts commit 88a3bb6.
…ing the webserver (go-gitea#3331)" I don't actually like this feature, since starting the web server with a default config creates a bunch of install files This reverts commit 88a3bb6.
Pretty simple. Since most gitea users won't ever need to touch any of the other functions, I see no need in requiring calling the web subcommand to run the webserver - thus I propose as a default action for the gitea command that of running the webserver.