Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden runner updateTask and updateLog api #32462

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

ChristopherHX
Copy link
Contributor

Per proposal #32461

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 9, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 9, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 9, 2024
@ChristopherHX
Copy link
Contributor Author

This change is coming from my static code analysis of the runner api for ephemeral runners, to no longer trust the runner from beeing wellbehaving.

@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Nov 9, 2024

https://github.com/go-gitea/gitea/actions/runs/11757416447/job/32754654149#step:4:245
image

Not shure why this CI check didn't fail, not changed by me.

golang/go#67182

Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the PR a draft?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 9, 2024
@ChristopherHX
Copy link
Contributor Author

Why is the PR a draft?

I haven't tested this locally yet, once done I change this.

@ChristopherHX ChristopherHX marked this pull request as ready for review November 10, 2024 10:11
@ChristopherHX
Copy link
Contributor Author

All good from my side after this change

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 11, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 11, 2024
@lunny lunny requested a review from wolfogre November 11, 2024 03:59
@lunny lunny enabled auto-merge (squash) November 11, 2024 04:23
@lunny lunny merged commit f888e45 into go-gitea:main Nov 11, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 11, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 11, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 13, 2024
* giteaofficial/main:
  Disable Oauth check if oauth disabled (go-gitea#32368)
  Update JS and PY dependencies (go-gitea#32482)
  Update `github.com/meilisearch/meilisearch-go` (go-gitea#32484)
  Fix test fixtures for user2/lfs.git (go-gitea#32477)
  Limit org member view of restricted users (go-gitea#32211)
  cargo registry - respect renamed dependencies (go-gitea#32430)
  Refactor LFS SSH and internal routers (go-gitea#32473)
  Fix a number of typescript issues (go-gitea#32459)
  Harden runner updateTask and updateLog api (go-gitea#32462)
  Move some functions from issue.go to standalone files (go-gitea#32468)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants