Improvements for supporting UI Location #3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
Codecov Report
@@ Coverage Diff @@
## master #3146 +/- ##
==========================================
+ Coverage 34.71% 34.72% +0.01%
==========================================
Files 276 276
Lines 39974 39975 +1
==========================================
+ Hits 13876 13881 +5
+ Misses 24102 24100 -2
+ Partials 1996 1994 -2
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
models/ssh_key.go
Outdated
| @@ -740,6 +736,12 @@ func GetDeployKeyByRepo(keyID, repoID int64) (*DeployKey, error) { | |||
| return key, nil | |||
| } | |||
|
|
|||
| // UpdateDeployKeyCols updates deploy key information only columns. | |||
There was a problem hiding this comment.
nit: // UpdateDeployKeyCols updates deploy key information only in the specified columns
| @@ -24,7 +25,7 @@ type TrackedTime struct { | |||
|
|
|||
| // AfterLoad is invoked from XORM after setting the values of all fields of this object. | |||
| func (t *TrackedTime) AfterLoad() { | |||
| t.Created = time.Unix(t.CreatedUnix, 0).Local() | |||
| t.Created = time.Unix(t.CreatedUnix, 0).In(setting.UILocation) | |||
There was a problem hiding this comment.
Why have we left the Created field in the TrackedTime struct?
There was a problem hiding this comment.
It has one json:"created" tag here. I should invistigate where referenced it. Maybe send a PR later.
lunny
force-pushed
the
lunny/ui_location
branch
from
dd202ec
to
394c764
Compare
|
should fix #3178 |
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.