-
-
Couldn't load subscription status.
- Fork 6.2k
Refactor struct's time to remove unnecessary memory usage #3142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #3142 +/- ##
=========================================
+ Coverage 34.66% 34.77% +0.1%
=========================================
Files 275 276 +1
Lines 40030 39945 -85
=========================================
+ Hits 13878 13889 +11
+ Misses 24173 24058 -115
- Partials 1979 1998 +19
Continue to review full report at Codecov.
|
|
LGTM |
This PR will remove unnecessary time.Time on almost all the structs and define a new time
type TimeStamp int64to handle the time. It's also improve theTimeSincewhere converted totime.Timeand convert back before. So that, manyBeforeInsertandAfterLoadis still unnecessary. The code is more clean.