Increase max length of org team names from 30 to 255 characters #31410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
GiteaBot
added
the
lgtm/need 2
techknowlogick
approved these changes
Jun 18, 2024
GiteaBot
added
lgtm/need 1
a1012112796
approved these changes
Jun 19, 2024
GiteaBot
added
lgtm/done
|
@techknowlogick do we need the migration mentioned in #31241 (comment)? |
|
@silverwind nope, the database already has that length, this PR only modifies the validation rules for creation/editing of the team names. |
|
Thanks @tobiasbp! |
wxiaoguang
added
backport/v1.22
|
Let's backport it |
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jun 19, 2024
…itea#31410) This PR modifies the structs for editing and creating org teams to allow team names to be up to 255 characters. The previous maximum length was 30 characters.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 20, 2024
* giteaofficial/main: Fix markdown math brackets render problem (go-gitea#31420) Reduce `air` verbosity (go-gitea#31417) Fix new issue/pr avatar (go-gitea#31419) Increase max length of org team names from 30 to 255 characters (go-gitea#31410)
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Jun 21, 2024
* origin/main: (21 commits) Fix deprecated Dockerfile ENV format (go-gitea#31450) README Badge maintenance (go-gitea#31441) Improve markdown textarea for indentation and lists (go-gitea#31406) Split common-global.js into separate files (go-gitea#31438) Fix the link for .git-blame-ignore-revs bypass (go-gitea#31432) Bump htmx to 2.0.0 (go-gitea#31413) Fix the wrong line number in the diff view page when expanded twice. (go-gitea#31431) Fix labels and projects menu overflow on issue page (go-gitea#31435) [Fix] Account Linking UpdateMigrationsByType (go-gitea#31428) Fix markdown math brackets render problem (go-gitea#31420) Reduce `air` verbosity (go-gitea#31417) Fix new issue/pr avatar (go-gitea#31419) Increase max length of org team names from 30 to 255 characters (go-gitea#31410) [skip ci] Updated translations via Crowdin Refactor names (go-gitea#31405) Update JS dependencies, remove `eslint-plugin-jquery` (go-gitea#31402) Switch to upstream of `gorilla/feeds` (go-gitea#31400) Fix rendered wiki page link (go-gitea#31398) Refactor repo unit "disabled" check (go-gitea#31389) Refactor route path normalization (go-gitea#31381) ...
This was referenced Jul 4, 2024
|
It seems no one actually tested it works. We need to be more dilligent and not assume that the contributor has actually tested their change in the absense of any automatic testing, like was the case here. |
lunny
pushed a commit
that referenced
this pull request
Jul 10, 2024
Gitea 1.22.1 was supposed to allow for team names of length 255 (up from 30) after the following PR was merged in: #31410. However, the length of team names was still limited to 30 as described in this issue: #31554. One more change to _gitea_ needs to be made to allow for the longer team names, as there is a 30 character limit here: https://github.com/go-gitea/gitea/blob/2c92c7c5226e29636a1d47a277130f477fa2037b/services/forms/org.go#L65 This PR changes that value to 255.
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jul 10, 2024
…#31564) Gitea 1.22.1 was supposed to allow for team names of length 255 (up from 30) after the following PR was merged in: go-gitea#31410. However, the length of team names was still limited to 30 as described in this issue: go-gitea#31554. One more change to _gitea_ needs to be made to allow for the longer team names, as there is a 30 character limit here: https://github.com/go-gitea/gitea/blob/2c92c7c5226e29636a1d47a277130f477fa2037b/services/forms/org.go#L65 This PR changes that value to 255.
techknowlogick
pushed a commit
that referenced
this pull request
Jul 10, 2024
…31603) Backport #31564 by @tobiasbp Gitea 1.22.1 was supposed to allow for team names of length 255 (up from 30) after the following PR was merged in: #31410. However, the length of team names was still limited to 30 as described in this issue: #31554. One more change to _gitea_ needs to be made to allow for the longer team names, as there is a 30 character limit here: https://github.com/go-gitea/gitea/blob/2c92c7c5226e29636a1d47a277130f477fa2037b/services/forms/org.go#L65 This PR changes that value to 255. Co-authored-by: Tobias Balle-Petersen <tobias.petersen@unity3d.com>
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Jul 16, 2024
Gitea 1.22.1 was supposed to allow for team names of length 255 (up from 30) after the following PR was merged in: go-gitea/gitea#31410. However, the length of team names was still limited to 30 as described in this issue: go-gitea/gitea#31554. One more change to _gitea_ needs to be made to allow for the longer team names, as there is a 30 character limit here: https://github.com/go-gitea/gitea/blob/2c92c7c5226e29636a1d47a277130f477fa2037b/services/forms/org.go#L65 This PR changes that value to 255. (cherry picked from commit 4ea2a6de81ab6adde436d77e2743095fafa6a7a9)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the structs for editing and creating org teams to allow team names to be up to 255 characters. The previous maximum length was 30 characters.