Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix natural sort #31384

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Fix natural sort #31384

merged 3 commits into from
Jun 17, 2024

Conversation

wxiaoguang
Copy link
Contributor

Fix #31374

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 15, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 15, 2024
@wxiaoguang wxiaoguang added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 15, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 15, 2024
@wxiaoguang wxiaoguang mentioned this pull request Jun 15, 2024
Closed
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 15, 2024
lunny
lunny approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about to send a patch to upstream?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 15, 2024
@wxiaoguang wxiaoguang added this to the 1.23.0 milestone Jun 16, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 17, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) June 17, 2024 06:32
@wxiaoguang wxiaoguang merged commit 25f3ec5 into go-gitea:main Jun 17, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 17, 2024
@wxiaoguang @GiteaBot
Fix natural sort (go-gitea#31384)
8183667 
Fix go-gitea#31374
@GiteaBot GiteaBot mentioned this pull request Jun 17, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jun 17, 2024
@wxiaoguang wxiaoguang deleted the fix-natural-sort branch June 17, 2024 06:49
wxiaoguang added a commit that referenced this pull request Jun 17, 2024
@GiteaBot @wxiaoguang
Fix natural sort (#31384) (#31394)
ed0fc0e 
Backport #31384 by wxiaoguang

Fix #31374

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 18, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b815a27 
* giteaofficial/main:
  Fix rendered wiki page link (go-gitea#31398)
  Refactor repo unit "disabled" check (go-gitea#31389)
  Refactor route path normalization (go-gitea#31381)
  Refactor markup code (go-gitea#31399)
  Add cache test for admins (go-gitea#31265)
  Fix double border in system status table (go-gitea#31363)
  Improve rubygems package registry (go-gitea#31357)
  Fix natural sort (go-gitea#31384)
  Fix missing images in editor preview due to wrong links (go-gitea#31299)
  Add a simple test for AdoptRepository (go-gitea#31391)
  [skip ci] Updated licenses and gitignores
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yp05327 yp05327 yp05327 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Files are not sorted alphabetically
4 participants
@wxiaoguang @lunny @yp05327 @GiteaBot