Update source installation requirements #3124
Conversation
We require Golang 1.8 since we use `net/url.PathEscape` which was not introduced until then
If we state Golang 1.8 we should test using that version as well
|
CI failed. |
tboerger
added
the
lgtm/need 2
|
LGTM. Maybe restart (commit amend or rebase) tests. |
tboerger
added
lgtm/need 1
|
CI failed seems related since I have restarted many times. |
.drone.yml
Outdated
| @@ -56,7 +56,7 @@ pipeline: | |||
| event: [ push, tag, pull_request ] | |||
|
|
|||
| build: | |||
| image: webhippie/golang:edge | |||
| image: webhippie/golang:1.8 | |||
There was a problem hiding this comment.
why not use edge in build step? as latest go versions tend to improve performance and reduce binary size
There was a problem hiding this comment.
Releases are maid under
Line 185 in ce7af57
There was a problem hiding this comment.
Yes but this but binary built in this step is used in docker images
There was a problem hiding this comment.
There is now step to test if it builds without gcc so that could be reused to test if it builds in 1.8
There was a problem hiding this comment.
With #2927 will be build inside first stage of docker ^^.
~~~From my point either edge or 1.8 is good since test stage will also check that the binary will compile.~~~
Edit: You mark a good point with docker binary ^^
|
@bkcsoft I hope you don't mind I changed back that edge as it's binary is used for docker image. To see if code compiles on 1.8 I changed build with no gcc step to :1.8 |
tboerger
added
lgtm/done
|
Note that git 1.7.10 is supported just fine, we're runnign it in production.
|
| @@ -17,7 +17,7 @@ menu: | |||
|
|
|||
| This section will not include basic [installation instructions](https://golang.org/doc/install). | |||
|
|
|||
| **Note**: Go version 1.7 or higher is required | |||
| **Note**: Go version 1.8 or higher is required | |||
There was a problem hiding this comment.
1.7.10 or higher is actually required
There was a problem hiding this comment.
Go Version, not Git Version :)
|
@strk it's about golang version needed to compile gitea code not git |
Codecov Report
@@ Coverage Diff @@
## master #3124 +/- ##
==========================================
- Coverage 35.58% 35.57% -0.01%
==========================================
Files 281 281
Lines 40571 40571
==========================================
- Hits 14438 14435 -3
- Misses 23994 23995 +1
- Partials 2139 2141 +2
Continue to review full report at Codecov.
|
|
Sorry for the confusion, keep GOing :)
|
We require Golang 1.8 since we use
net/url.PathEscapewhich was not introduced until thenurl.PathEscapeintroduction into Golang: golang/go@7e2bf95Introduction into Gitea: https://github.com/go-gitea/gitea/pull/2996/files#diff-7e18c3b28c00aad8476da1a8231f6864R109
Closes #3123
Also changed the tests to run against what we state as the requirement...