Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repo indexer and submodule bug #3107

Merged
merged 2 commits into from
Dec 7, 2017
Merged

Fix repo indexer and submodule bug #3107

merged 2 commits into from
Dec 7, 2017

Conversation

ethantkoenig
Copy link
Member

Fixes #3098. Also removes an unused struct.

@codecov-io
Copy link

codecov-io commented Dec 7, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@311c83a). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3107   +/-   ##
=========================================
  Coverage          ?   34.05%           
=========================================
  Files             ?      274           
  Lines             ?    40023           
  Branches          ?        0           
=========================================
  Hits              ?    13631           
  Misses            ?    24454           
  Partials          ?     1938
Impacted Files Coverage Δ
models/repo_indexer.go 44.66% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 311c83a...0b60513. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 7, 2017
@lafriks
Copy link
Member

lafriks commented Dec 7, 2017

LGTM

@lunny lunny added this to the 1.4.0 milestone Dec 7, 2017
@lunny
Copy link
Member

lunny commented Dec 7, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 7, 2017
@lunny lunny merged commit 5e4427e into go-gitea:master Dec 7, 2017
@lunny
Copy link
Member

lunny commented Dec 7, 2017

@ethantkoenig please send a backport to release/v1.3

ethantkoenig added a commit to ethantkoenig/gitea that referenced this pull request Dec 7, 2017
@ethantkoenig
Fix repo indexer and submodule bug (go-gitea#3107)
a0d48cc
@ethantkoenig ethantkoenig mentioned this pull request Dec 7, 2017
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Dec 7, 2017
lunny pushed a commit that referenced this pull request Dec 8, 2017
@ethantkoenig @lunny
Fix repo indexer and submodule bug (#3107) (#3110)
8435231 
* Fix repo indexer and submodule bug (#3107)

* Empty commit to re-trigger CI
@ethantkoenig ethantkoenig deleted the fix/repo_index_submodule branch December 18, 2017 06:09
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Initialization of the Repository index fails
5 participants
@ethantkoenig @codecov-io @lafriks @lunny @tboerger