Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align s3 files with docker naming #31050

Merged
merged 2 commits into from
May 22, 2024
Merged

align s3 files with docker naming #31050

merged 2 commits into from
May 22, 2024

Conversation

techknowlogick
Copy link
Member

docker images have -nightly, this will append the same to binaries uploaded to s3.

@techknowlogick techknowlogick added topic/deployment skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.22 This PR should be backported to Gitea 1.22 labels May 22, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 22, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 22, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 22, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) May 22, 2024 20:26
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 22, 2024
@techknowlogick techknowlogick merged commit 90f4cf5 into go-gitea:main May 22, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 22, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 22, 2024
@techknowlogick @GiteaBot
align s3 files with docker naming (go-gitea#31050)
8ccc81b 
docker images have `-nightly`, this will append the same to binaries
uploaded to s3.
@GiteaBot GiteaBot mentioned this pull request May 22, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 22, 2024
@wxiaoguang
Copy link
Contributor

wxiaoguang commented May 23, 2024 •
edited
Loading

Thank you for the change (https://dl.gitea.com/gitea/main-nightly/)

Should we also update the document and remove the legacy "main" directory? And should we also backport it to 1.22 to have "1.22-nightly"? (just see the backport label 👍)

techknowlogick pushed a commit that referenced this pull request May 23, 2024
@GiteaBot
align s3 files with docker naming (#31050) (#31052)
14ed06d
@techknowlogick techknowlogick deleted the nightly-on-releases branch May 23, 2024 00:07
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 23, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8c7e0bf 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  align s3 files with docker naming (go-gitea#31050)
  Sync up deleted branches & action assets related cleanup documentation (go-gitea#31022)
  Update Actions documentation missing feature (go-gitea#31034)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/deployment
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@techknowlogick @wxiaoguang @lunny @delvh @GiteaBot