Skip to content

Fix a panic bug when head repository deleting (#30674) #30676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 25, 2024
Merged

Fix a panic bug when head repository deleting (#30674) #30676

merged 5 commits into from
Apr 25, 2024

Conversation

@GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Apr 24, 2024 •
edited by lunny
Loading

Backport #30674 & #30679 by @lunny

When visiting a pull request files which head repository has been deleted, it will panic because headrepo is nil.

@lunny @GiteaBot
Fix a panic bug when head repository deleting (go-gitea#30674)
c2ff032 
When visiting a pull request files which head repository has been
deleted, it will panic because headrepo is nil.
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code type/bug labels Apr 24, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Apr 24, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 24, 2024
@GiteaBot GiteaBot requested review from Zettat123 and yp05327 April 24, 2024 05:27
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 24, 2024
@yp05327 yp05327 self-requested a review April 24, 2024 06:43
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Apr 24, 2024
@yp05327
Copy link
Contributor

yp05327 commented Apr 24, 2024

wait. tests are added.

yp05327
yp05327 reviewed Apr 24, 2024
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2024
yp05327
yp05327 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@yp05327 yp05327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz also fix the problem in the original pr

@lunny lunny merged commit bb6edb2 into go-gitea:release/v1.22 Apr 25, 2024
@yp05327 yp05327 mentioned this pull request Apr 25, 2024
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@yp05327 yp05327 yp05327 approved these changes

@Zettat123 Zettat123 Awaiting requested review from Zettat123

Assignees

@lunny lunny

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

1.22.0

Development

Successfully merging this pull request may close these issues.

3 participants

@GiteaBot @yp05327 @lunny