Skip to content

Conversation

@jpraet
Copy link
Member

@jpraet jpraet commented Mar 16, 2024

Fixes #28297

This PR also fixed a problem that it needs a database transaction when removing the WIP title.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 16, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 16, 2024
@silverwind
Copy link
Member

silverwind commented Mar 16, 2024

Strange error on CI, may be related. I will restart it once.

Error: The action 'run tests' has timed out after 50 minutes.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 16, 2024
@jpraet
Copy link
Member Author

jpraet commented Mar 16, 2024

Strange error on CI, may be related. I will restart it once.

Error: The action 'run tests' has timed out after 50 minutes.

It hangs in test === TestPullView_CodeOwner (tests/integration/pull_review_test.go:36), so it is related.
But I don't know how to fix it.

@lunny
Copy link
Member

lunny commented Mar 17, 2024

Strange error on CI, may be related. I will restart it once.

Error: The action 'run tests' has timed out after 50 minutes.

It hangs in test === TestPullView_CodeOwner (tests/integration/pull_review_test.go:36), so it is related. But I don't know how to fix it.

I will do some debug.

@splitt3r
Copy link
Contributor

Strange error on CI, may be related. I will restart it once.

Error: The action 'run tests' has timed out after 50 minutes.

It hangs in test === TestPullView_CodeOwner (tests/integration/pull_review_test.go:36), so it is related. But I don't know how to fix it.

I will do some debug.

Maybe https://codeberg.org/forgejo/forgejo/pulls/1970#issuecomment-1532769 could be the reason or at least relevant here.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 19, 2024
@lunny lunny enabled auto-merge (squash) March 19, 2024 05:01
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 19, 2024
@lunny lunny merged commit 17d7ab5 into go-gitea:main Mar 19, 2024
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 19, 2024
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.21. @jpraet, please send one manually. 🍵

go run ./contrib/backport 29842
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 19, 2024
lunny pushed a commit to lunny/gitea that referenced this pull request Mar 19, 2024
@lunny lunny added the backport/done All backports for this PR have been created label Mar 19, 2024
lunny added a commit that referenced this pull request Mar 20, 2024
backport #29842

Co-authored-by: Jimmy Praet <jimmy.praet@telenet.be>
@lunny lunny modified the milestones: 1.23.0, 1.22.0 Mar 22, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Notify reviewer added in pull request via codeowners file

7 participants