Fix wrong test usage of AppSubURL
#29459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
the
modifies/api
silverwind
approved these changes
Feb 27, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Feb 27, 2024
GiteaBot
added
lgtm/done
delvh
approved these changes
Feb 27, 2024
lunny
added
backport/v1.21
wxiaoguang
reviewed
Feb 28, 2024
| Repo = "gogits/gogs" | ||
| AppSubURL = AppURL + Repo + "/" | ||
| AppURL = "http://localhost:3000/" | ||
| FullURL = AppURL + "gogits/gogs/" |
There was a problem hiding this comment.
What does this mean?
Why "AppURL" is "http://localhost:3000/" but there is "gogits/gogs/" in FullURL?
- If the "gogits/gogs/" is for sub URL, then it should define AppSubURL to "/gogits/gogs"
- If the "gogits/gogs/" is for a repo like "user/repo", then it shouldn't be provided here.
There was a problem hiding this comment.
The repo info is in line 30+31. The localMetas is global for the following tests, so the full url is build here too. Where would you put that code?
There was a problem hiding this comment.
Thank you. Maybe it could be called RepoFullURL. I have no more question now.
wxiaoguang
removed
the
reviewed/wait-merge
wxiaoguang
approved these changes
Feb 29, 2024
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Feb 29, 2024
The tests use an invalid `setting.AppSubURL`. The wrong behaviour disturbs other PRs like go-gitea#29222 and go-gitea#29427.
GiteaBot
added
backport/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 29, 2024
* giteaofficial/main: (23 commits) Fix wrong test usage of `AppSubURL` (go-gitea#29459) Improve contrast on blame timestamp, fix double border (go-gitea#29482) Fix/Improve `processWindowErrorEvent` (go-gitea#29407) Apply compact padding to small buttons with svg icons (go-gitea#29471) Fix counter display number incorrectly displayed on the page (go-gitea#29448) Fix incorrect user location link on profile page (go-gitea#29474) Fix workflow trigger event bugs (go-gitea#29467) Fix URL calculation in clone input box (go-gitea#29470) Remove jQuery from the "find file" page (go-gitea#29456) Move generate from module to service (go-gitea#29465) The job should always run when `if` is `always()` (go-gitea#29464) Recolor dark theme to blue shade (go-gitea#29283) Let ctx.FormOptionalBool() return optional.Option[bool] (go-gitea#29461) Implement actions badge svgs (go-gitea#28102) Fix missed return (go-gitea#29450) Use tailwind instead of `gt-[wh]-` helper classes (go-gitea#29423) Lock issues and pulls faster (go-gitea#29436) Allow to change primary email before account activation (go-gitea#29412) Update docs about `DEFAULT_ACTIONS_URL` (go-gitea#29442) Only use supported sort order for "explore/users" page (go-gitea#29430) ...
lunny
pushed a commit
that referenced
this pull request
Feb 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests use an invalid
setting.AppSubURL. The wrong behaviour disturbs other PRs like #29222 and #29427.