Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document our issue locking policy #29433

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Document our issue locking policy #29433

merged 1 commit into from
Feb 26, 2024

Conversation

delvh
Copy link
Member

@delvh delvh commented Feb 26, 2024

Now, we explicitly state that conversations on merged PRs can be locked pre-emptively.

@delvh delvh added the type/docs This PR mainly updates/creates documentation label Feb 26, 2024
@delvh delvh self-assigned this Feb 26, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 26, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 26, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 26, 2024
@6543 6543 requested a review from a team February 26, 2024 20:17
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 26, 2024
@techknowlogick techknowlogick merged commit 4f70ebb into go-gitea:main Feb 26, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 26, 2024
@6543 6543 mentioned this pull request Feb 26, 2024
Merged
@delvh delvh deleted the document-locking-policy branch February 26, 2024 23:30
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 27, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
ddef710 
* giteaofficial/main:
  Fix mail template error (go-gitea#29410)
  Document our issue locking policy (go-gitea#29433)
  Fix htmx rendering the login page in frame on session logout (go-gitea#29405)
  Ignore empty repo for CreateRepository in action notifier (go-gitea#29416)
  Fix incorrect tree path value for patch editor (go-gitea#29377)
  Fix logic error from go-gitea#28138 (go-gitea#29417)
lunny pushed a commit that referenced this pull request Feb 27, 2024
@6543
Lock issues and pulls faster (#29436)
0900c15 
also point to the docs to explain why we do so

followup to  #29433
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justusbunsi justusbunsi justusbunsi approved these changes

@jolheiser jolheiser jolheiser approved these changes

@6543 6543 6543 approved these changes

Assignees

@delvh delvh

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@delvh @6543 @jolheiser @justusbunsi @techknowlogick @GiteaBot