Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix files/commits of merged PRs #2937

Merged
merged 2 commits into from
Nov 25, 2017
Merged

Fix files/commits of merged PRs #2937

merged 2 commits into from
Nov 25, 2017

Conversation

ethantkoenig
Copy link
Member

Fixes #2797. Instead of looking at the range <base>...<merge-commit>, look at the range <base>...<end-commit> for determining commits and file diffs.

@codecov-io
Copy link

codecov-io commented Nov 19, 2017 •
edited
Loading

Codecov Report

Merging #2937 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2937   +/-   ##
======================================
  Coverage    26.8%   26.8%           
======================================
  Files          90      90           
  Lines       17807   17807           
======================================
  Hits         4774    4774           
  Misses      12353   12353           
  Partials      680     680

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 183da4c...efd1817. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 19, 2017
@lunny lunny added the type/bug label Nov 20, 2017
@lunny lunny added this to the 1.x.x milestone Nov 20, 2017
@lafriks
Copy link
Member

lafriks commented Nov 20, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 20, 2017
@lunny lunny modified the milestones: 1.x.x, 1.4.0 Nov 21, 2017
@deguif
Copy link

deguif commented Nov 23, 2017

Anyone to review it?
Would love to see this merged quickly as this a really inconvenient issue.

@lunny
Copy link
Member

lunny commented Nov 25, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 25, 2017
@lunny lunny merged commit 40c545d into go-gitea:master Nov 25, 2017
@lunny
Copy link
Member

lunny commented Nov 25, 2017

Please send back port to v1.3

@ethantkoenig ethantkoenig mentioned this pull request Nov 25, 2017
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Nov 25, 2017
@ethantkoenig ethantkoenig deleted the fix/2797 branch December 18, 2017 06:09
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

PR revisions tab show more commits after being merged
6 participants
@ethantkoenig @codecov-io @lafriks @deguif @lunny @tboerger