Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine identical Makefile rules #2916

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Combine identical Makefile rules #2916

merged 1 commit into from
Nov 17, 2017

Conversation

ethantkoenig
Copy link
Member

Combine identical integrations.mysql.test and integrations.pgsql.test targets into a single integrations.test target; no need to compile twice.

@codecov-io
Copy link

codecov-io commented Nov 15, 2017 •
edited
Loading

Codecov Report

Merging #2916 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2916      +/-   ##
==========================================
- Coverage   27.26%   27.24%   -0.02%     
==========================================
  Files          89       89              
  Lines       17640    17640              
==========================================
- Hits         4809     4806       -3     
- Misses      12144    12146       +2     
- Partials      687      688       +1
Impacted Files Coverage Δ
modules/process/manager.go 69.56% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb0181...f50fa9b. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 15, 2017
@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Nov 15, 2017
@lafriks lafriks added this to the 1.4.0 milestone Nov 15, 2017
@lafriks
Copy link
Member

lafriks commented Nov 15, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 15, 2017
@lunny lunny added type/testing and removed topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Nov 15, 2017
@lunny
Copy link
Member

lunny commented Nov 15, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 15, 2017
@lunny
Copy link
Member

lunny commented Nov 15, 2017

But CI failed. It should be related.

@lunny lunny merged commit 6ee6575 into go-gitea:master Nov 17, 2017
sapk added a commit to sapk-fork/gitea that referenced this pull request Nov 25, 2017
@sapk
Fix bench deps since go-gitea#2916
8e58b15
@sapk sapk mentioned this pull request Nov 25, 2017
Merged
lunny pushed a commit that referenced this pull request Nov 26, 2017
@sapk @lunny
Fix bench deps since #2916 (#2971)
d23a3e9
@ethantkoenig ethantkoenig deleted the test/makefile branch December 18, 2017 06:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ethantkoenig @codecov-io @lafriks @lunny @appleboy @tboerger