Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more settings for empty repositories #29130

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

zokkis
Copy link
Contributor

@zokkis zokkis commented Feb 10, 2024

Shows more settings for empty repositories with setting EnableCode true (Fixes #29060)

before:
image

after:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 10, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 10, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Feb 10, 2024
@zokkis zokkis changed the title Show more settings for non-empty repositories Show more settings for empty repositories Feb 10, 2024
@delvh
Copy link
Member

delvh commented Feb 10, 2024

In other words, reverts #28631?

@delvh
Copy link
Member

delvh commented Feb 10, 2024

As I already mentioned in the PR above, the best approach would probably be to disable the settings and display a tooltip why it is disabled.

@zokkis
Copy link
Contributor Author

zokkis commented Feb 10, 2024

In other words, reverts #28631?

No its not a revert
When you disable the setting Access source code, files, commits and branches. its correct to disable the settings, but not on empty repos
image

And enable this setting on a empty repo shows the settings
image

@zokkis
Copy link
Contributor Author

zokkis commented Feb 10, 2024

As I already mentioned in the PR above, the best approach would probably be to disable the settings and display a tooltip why it is disabled.

Then this should be work for all settings like

  • webhooks
  • branches
  • tags
  • git-hooks
  • ssh-keys
  • lfs
  • runners/secrets/variables

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 11, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 11, 2024
@delvh
Copy link
Member

delvh commented Feb 11, 2024

Regarding my previous comment: I misunderstood you, I thought you meant showing all settings even when code is disabled. Not for empty repos.
But yeah, it might as well apply to this, but only in the future.

@delvh delvh added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Feb 11, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) February 11, 2024 13:49
@wxiaoguang wxiaoguang merged commit 28db539 into go-gitea:main Feb 11, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 11, 2024
@zokkis zokkis deleted the enhancement/show-more-settings branch February 11, 2024 14:46
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 14, 2024
* giteaofficial/main: (38 commits)
  Document how the TOC election process works (go-gitea#29135)
  Runner tokens are multi use (go-gitea#29153)
  Fix Gitpod logic of setting ROOT_URL (go-gitea#29162)
  Remove jQuery from the user search form in admin page (go-gitea#29151)
  Dont load Review if Comment is CommentTypeReviewRequest (go-gitea#28551)
  Show `View at this point in history` for every commit (go-gitea#29122)
  [skip ci] Updated translations via Crowdin
  Add merge style `fast-forward-only` (go-gitea#28954)
  Use Markdown alert syntax for notes in README (go-gitea#29150)
  Refactor issue template parsing and fix API endpoint (go-gitea#29069)
  [skip ci] Updated translations via Crowdin
  Update some translations and fix markdown formatting (go-gitea#29099)
  Show more settings for empty repositories (go-gitea#29130)
  Update JS and PY dependencies (go-gitea#29127)
  Add alert blocks in markdown (go-gitea#29121)
  Remove obsolete border-radius on comment content (go-gitea#29128)
  Make blockquote border size less aggressive (go-gitea#29124)
  Drop "@" from email sender to avoid spam filters (go-gitea#29109)
  [skip ci] Updated translations via Crowdin
  Disallow duplicate storage paths (go-gitea#26484)
  ...
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
Shows more settings for empty repositories (Fixes go-gitea#29060)
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
Shows more settings for empty repositories (Fixes go-gitea#29060)

(cherry picked from commit 28db539)
Copy link

github-actions bot commented Mar 1, 2024

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
@lunny lunny added backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 labels Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy keys no longer available for uninitialized repository
5 participants