Rework spellchecking, add lint-spell
#29106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
silverwind
added
the
skip-changelog
silverwind
force-pushed
the
spell
branch
2 times, most recently
from
90b46ec to
7511383
Compare
wxiaoguang
approved these changes
Feb 9, 2024
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Feb 9, 2024
GiteaBot
added
lgtm/done
Member
|
Setting backport on this due to docs changes |
Collaborator
|
I was unable to create a backport for 1.21. @silverwind, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
Member
Author
|
I forgot adding |
silverwind
added a commit
that referenced
this pull request
Feb 9, 2024
Followup to #29106, fix this oversight.
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Feb 9, 2024
- Use maintained fork https://github.com/golangci/misspell - Rename `mispell-check` to `lint-spell`, add `lint-spell-fix` - Run `lint-spell` in separate actions step - Lint more files, fix discovered issues - Remove inaccurate and outdated info in docs (we do not need GOPATH for tools anymore) Maybe later we can add more spellchecking tools, but I have not found any good ones yet.
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Feb 9, 2024
Followup to go-gitea#29106, fix this oversight.
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Feb 10, 2024
Followup to go-gitea/gitea#29106, fix this oversight. (cherry picked from commit c7a21cb)
KN4CK3R
pushed a commit
that referenced
this pull request
Feb 17, 2024
backport #27530 to make pull request lint happy https://github.com/go-gitea/gitea/actions/runs/7939560756/job/21679856929?pr=29206 since #29106 --------- Co-authored-by: techknowlogick <techknowlogick@gitea.com>
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
- Use maintained fork https://github.com/golangci/misspell - Rename `mispell-check` to `lint-spell`, add `lint-spell-fix` - Run `lint-spell` in separate actions step - Lint more files, fix discovered issues - Remove inaccurate and outdated info in docs (we do not need GOPATH for tools anymore) Maybe later we can add more spellchecking tools, but I have not found any good ones yet.
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Followup to go-gitea#29106, fix this oversight.
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
- Use maintained fork https://github.com/golangci/misspell - Rename `mispell-check` to `lint-spell`, add `lint-spell-fix` - Run `lint-spell` in separate actions step - Lint more files, fix discovered issues - Remove inaccurate and outdated info in docs (we do not need GOPATH for tools anymore) Maybe later we can add more spellchecking tools, but I have not found any good ones yet. (cherry picked from commit 9c39f85) Conflicts: .github/workflows/pull-compliance.yml Makefile
|
Automatically locked because of our CONTRIBUTING guidelines |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mispell-checktolint-spell, addlint-spell-fixlint-spellin separate actions stepMaybe later we can add more spellchecking tools, but I have not found any good ones yet.