Avoid showing unnecessary JS errors when there are elements with different origin on the page #29081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
fix-sop-js-error
branch
from
43ab996 to
240567b
Compare
silverwind
reviewed
Feb 7, 2024
| return false; | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Could we detect the iframe document via el.ownerDocument !== document and ignore those? I don't think we want to run the mutation callbacks on any iframe content (mermaid and user-configured renderers are the only cases I know of).
Contributor
Author
There was a problem hiding this comment.
done in 6299b57 , and added more comments
silverwind
approved these changes
Feb 7, 2024
Member
silverwind
left a comment
silverwind
left a comment
There was a problem hiding this comment.
I guess it is fine as-is, so above comment is an optional enhancement.
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Feb 8, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Feb 8, 2024
…erent origin on the page (go-gitea#29081) Try to fix go-gitea#29080
GiteaBot
added
backport/done
wxiaoguang
added a commit
that referenced
this pull request
Feb 8, 2024
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
…erent origin on the page (go-gitea#29081) Try to fix go-gitea#29080
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
…ith different origin on the page (go-gitea#29081) Try to fix go-gitea#29080 (cherry picked from commit f290c24)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #29080