Skip to content

Conversation

@wiktor-k
Copy link
Contributor

@wiktor-k wiktor-k commented Feb 7, 2024

Outgoing new release e-mail notifications were missing links to the actual release. An example from Codeberg.org e-mail:

<a href=3D"">View it on Codeberg.org</a>.<br/>

This PR adds "Link" context property pointing to the release on the web interface.

The change was tested using [mailer] PROTOCOL=dummy.

Outgoing new release e-mail notifications were missing links to
the actual release. An example from Codeberg.org e-mail:

    <a href=3D"">View it on Codeberg.org</a>.<br/>

This PR adds `"Link"` context property pointing to the release on
the web interface.

The change was tested using `[mailer] PROTOCOL=dummy`.

Signed-off-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 7, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 7, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2024
@lunny lunny added type/bug backport/v1.21 reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Feb 8, 2024
@lunny lunny enabled auto-merge (squash) February 8, 2024 02:34
@lunny lunny merged commit 37191dc into go-gitea:main Feb 8, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 8, 2024
@GiteaBot
Copy link
Collaborator

GiteaBot commented Feb 8, 2024

I was unable to create a backport for 1.21. @wiktor-k, please send one manually. 🍵

go run ./contrib/backport 29079
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Feb 8, 2024
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
Outgoing new release e-mail notifications were missing links to the
actual release. An example from Codeberg.org e-mail:

    <a href=3D"">View it on Codeberg.org</a>.<br/>

This PR adds `"Link"` context property pointing to the release on the
web interface.

The change was tested using `[mailer] PROTOCOL=dummy`.

Signed-off-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
wxiaoguang pushed a commit to wxiaoguang/gitea that referenced this pull request Feb 21, 2024
Outgoing new release e-mail notifications were missing links to the
actual release. An example from Codeberg.org e-mail:

    <a href=3D"">View it on Codeberg.org</a>.<br/>

This PR adds `"Link"` context property pointing to the release on the
web interface.

The change was tested using `[mailer] PROTOCOL=dummy`.

Signed-off-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Feb 21, 2024
KN4CK3R added a commit that referenced this pull request Feb 21, 2024
Backport #29079

Signed-off-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
Co-authored-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
…tea#29079)

Outgoing new release e-mail notifications were missing links to the
actual release. An example from Codeberg.org e-mail:

    <a href=3D"">View it on Codeberg.org</a>.<br/>

This PR adds `"Link"` context property pointing to the release on the
web interface.

The change was tested using `[mailer] PROTOCOL=dummy`.

Signed-off-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
(cherry picked from commit 37191dc)
@github-actions
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
@wiktor-k wiktor-k deleted the wiktor/fix-release-link branch February 29, 2024 06:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants