Refactor parseSignatureFromCommitLine #29054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
fix-commiter-parser
branch
from
7d59e8f to
d4240dc
Compare
lunny
approved these changes
Feb 5, 2024
GiteaBot
added
lgtm/need 1
yp05327
reviewed
Feb 7, 2024
yp05327
approved these changes
Feb 9, 2024
GiteaBot
added
lgtm/done
Contributor
|
The output format is based on the git command, so we can control it. |
Contributor
Author
Let's only put this change in 1.22. For the backport, I will still add the legacy format support, to avoid any breaking 😄 |
Collaborator
|
I was unable to create a backport for 1.21. @wxiaoguang, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Feb 9, 2024
Replace go-gitea#28849. Thanks to @yp05327 for the looking into the problem. Fix go-gitea#28840 The old behavior of newSignatureFromCommitline is not right. The new parseSignatureFromCommitLine: 1. never fails 2. only accept one format (if there is any other, it could be easily added) And add some tests.
KN4CK3R
pushed a commit
that referenced
this pull request
Feb 9, 2024
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Replace go-gitea#28849. Thanks to @yp05327 for the looking into the problem. Fix go-gitea#28840 The old behavior of newSignatureFromCommitline is not right. The new parseSignatureFromCommitLine: 1. never fails 2. only accept one format (if there is any other, it could be easily added) And add some tests.
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
Replace go-gitea#28849. Thanks to @yp05327 for the looking into the problem. Fix go-gitea#28840 The old behavior of newSignatureFromCommitline is not right. The new parseSignatureFromCommitLine: 1. never fails 2. only accept one format (if there is any other, it could be easily added) And add some tests. (cherry picked from commit a24e1da)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #28849. Thanks to @yp05327 for the looking into the problem.
Fix #28840
The old behavior of newSignatureFromCommitline is not right. The new parseSignatureFromCommitLine:
And add some tests.