Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect button CSS usages (#29015) #29023

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Fix incorrect button CSS usages (#29015) #29023

merged 1 commit into from
Feb 2, 2024

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Feb 1, 2024

Backport #29015 by @wxiaoguang

Fix 2 problems:

  1. Remove the legacy (non-existing) CSS: class="btn btn-gray btn-radius"
  2. Remove the button styles inside the ui message, according to: https://fomantic-ui.com/collections/message.html , the button shouldn't have any border/padding.

Before

image

image

After

image

image

@GiteaBot GiteaBot added modifies/templates This PR modifies the template files type/enhancement An improvement of existing functionality labels Feb 1, 2024
@GiteaBot GiteaBot added this to the 1.21.5 milestone Feb 1, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 1, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 1, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 2, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 2, 2024
@silverwind silverwind merged commit 333d02d into go-gitea:release/v1.21 Feb 2, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 2, 2024
@lunny lunny modified the milestones: 1.21.5, 1.21.6 Feb 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@silverwind silverwind silverwind approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees

@wxiaoguang wxiaoguang

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.6
Development

Successfully merging this pull request may close these issues.
5 participants
@GiteaBot @silverwind @lafriks @lunny @wxiaoguang