Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test for user deleting account #2891

Merged
merged 2 commits into from
Nov 12, 2017
Merged

Integration test for user deleting account #2891

merged 2 commits into from
Nov 12, 2017

Conversation

ethantkoenig
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 11, 2017 •
edited
Loading

Codecov Report

Merging #2891 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2891   +/-   ##
=======================================
  Coverage   26.85%   26.85%           
=======================================
  Files          89       89           
  Lines       17607    17607           
=======================================
  Hits         4728     4728           
  Misses      12193    12193           
  Partials      686      686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5abd1d2...c5101cf. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 11, 2017
lafriks
lafriks requested changes Nov 11, 2017
View reviewed changes
integrations/integration_test.go Outdated
@@ -1,4 +1,3 @@
// Copyright 2017 The Gitea Authors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, good catch

@lafriks lafriks added this to the 1.x.x milestone Nov 11, 2017
@lafriks lafriks modified the milestones: 1.x.x, 1.3.0 Nov 12, 2017
@lafriks
Copy link
Member

lafriks commented Nov 12, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 12, 2017
@lunny
Copy link
Member

lunny commented Nov 12, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 12, 2017
@lunny lunny merged commit 47f40cc into go-gitea:master Nov 12, 2017
@ethantkoenig ethantkoenig deleted the test/user_delete_account branch November 14, 2017 03:29
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ethantkoenig @codecov-io @lafriks @lunny @tboerger