Fix reviewers notification #28543
Open
Fix reviewers notification #28543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move codeowner related code out of the models package, as they quite frankly don't have anything to do with database models. It has been moved to `modules/codeowner` for the codeowner file parsing and `services/issue` for the assinging of codeowners to pull requests. Refs: https://codeberg.org/forgejo/forgejo/pulls/1970 (cherry picked from commit ea6942585d43dba8b038758782631e58ea8a34b4)
- In `PullRequestCodeOwnersReview` use the correct functions that will notify added reviewers. Refs: https://codeberg.org/forgejo/forgejo/pulls/1970 (cherry picked from commit c3bdc5698901768c6a3f016cde9ff03072a5cc77)
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XL
lunny
reviewed
Jan 4, 2024
|
|
||
| for _, u := range uniqUsers { | ||
| if u.ID != pull.Poster.ID { | ||
| if _, err := ReviewRequest(ctx, pull, pull.Poster, u, true); err != nil { |
There was a problem hiding this comment.
On services/pull/pull.go:129, the transaction hasn't been submitted but the notifications on ReviewRequest and TeamReviewRequest will be sent immediately. It's not safe enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PullRequestCodeOwnersReviewuse the correct functions that willnotify added reviewers.
Refs: https://codeberg.org/forgejo/forgejo/pulls/1970