Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attachments icon size on zoom in/out #2853

Merged
merged 3 commits into from
Nov 5, 2017
Merged

Fix attachments icon size on zoom in/out #2853

merged 3 commits into from
Nov 5, 2017

Conversation

lenisko
Copy link
Contributor

@lenisko lenisko commented Nov 4, 2017

Icon of attached file (other then image) in issue is broken on zooming page in/out.
I was able to fix it by providing static size, which fits space perfectly.

I'm on master branch atm.

Before change on zoom out
29-2017-11-05-00-07-17_firefox

After change
30-2017-11-05-00-08-03_firefox

Cheers!

@Morlinest
Copy link
Member

You need to run make generate-stylesheets

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 4, 2017
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Nov 5, 2017
@lafriks lafriks added this to the 1.x.x milestone Nov 5, 2017
@codecov-io
Copy link

codecov-io commented Nov 5, 2017

Codecov Report

Merging #2853 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2853   +/-   ##
=======================================
  Coverage   26.85%   26.85%           
=======================================
  Files          89       89           
  Lines       17607    17607           
=======================================
  Hits         4728     4728           
  Misses      12193    12193           
  Partials      686      686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bdce5d...9c953de. Read the comment docs.

@lafriks
Copy link
Member

lafriks commented Nov 5, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 5, 2017
@Morlinest
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 5, 2017
@lafriks lafriks modified the milestones: 1.x.x, 1.3.0 Nov 5, 2017
@lafriks lafriks merged commit 80a4643 into go-gitea:master Nov 5, 2017
@lenisko lenisko deleted the lenisko-patch-1 branch November 13, 2017 16:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants