Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deleted_branch table fixture #2832

Merged
merged 4 commits into from
Nov 4, 2017
Merged

Add deleted_branch table fixture #2832

merged 4 commits into from
Nov 4, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Nov 2, 2017

As title

@lafriks lafriks added this to the 1.3.0 milestone Nov 2, 2017
@Morlinest
Copy link
Member

Why we need this "empty" file?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 2, 2017
@lafriks
Copy link
Member Author

lafriks commented Nov 2, 2017

@Morlinest to reset table to empty (delete all rows) between tests, otherwise anything that gets inserted there stays between tests that can result in failures or unexpected behaviour.

@Morlinest
Copy link
Member

@lafriks OK, that makes sense.

@lunny
Copy link
Member

lunny commented Nov 3, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 3, 2017
@lunny
Copy link
Member

lunny commented Nov 3, 2017

CI failed.

@lafriks
Copy link
Member Author

lafriks commented Nov 4, 2017

@lunny Tests where abusing that deleted branches table was not cleared between tests so I had to fix them :)

@Morlinest
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 4, 2017
@codecov-io
Copy link

Codecov Report

Merging #2832 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2832   +/-   ##
=======================================
  Coverage   26.85%   26.85%           
=======================================
  Files          89       89           
  Lines       17607    17607           
=======================================
  Hits         4728     4728           
  Misses      12193    12193           
  Partials      686      686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1621069...84c1f2b. Read the comment docs.

@lafriks lafriks merged commit bd6f24b into go-gitea:master Nov 4, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @Morlinest @lunny @codecov-io @tboerger