Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second part of refactor db.Find #28194

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Second part of refactor db.Find #28194

merged 6 commits into from
Dec 11, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 24, 2023 •
edited
Loading

Continue of #27798 and move more functions to db.Find and db.Count.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 24, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 24, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 24, 2023
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Nov 24, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 5, 2023
@delvh delvh changed the title Refacort db.Find second party Second part of refactor db.Find Dec 5, 2023
@delvh
Copy link
Member

delvh commented Dec 11, 2023

ping for other maintainers

@lunny lunny changed the title Second part of refactor db.Find Second part of refactor db.Find Dec 11, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2023
@lunny lunny merged commit 537fa69 into go-gitea:main Dec 11, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Dec 11, 2023
@lunny lunny deleted the lunny/refacto_find2 branch December 11, 2023 08:56
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 12, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
de9f6d8 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Let `curl` write the content to file (go-gitea#28427)
  Improve doctor cli behavior (go-gitea#28422)
  Second part of refactor `db.Find` (go-gitea#28194)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@lunny @fuxiaohei
Second part of refactor db.Find (go-gitea#28194)
901b507 
Continue of go-gitea#27798 and move more functions to `db.Find` and `db.Count`.
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@lunny @silverwind
Second part of refactor db.Find (go-gitea#28194)
b51c196 
Continue of go-gitea#27798 and move more functions to `db.Find` and `db.Count`.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @delvh @wolfogre @GiteaBot