Fix API status code for hook creation #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethantkoenig
force-pushed
the
fix/hook_api
branch
from
767f5e7
to
e586a7d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2814 +/- ##
==========================================
- Coverage 27.26% 27.24% -0.02%
==========================================
Files 89 89
Lines 17640 17640
==========================================
- Hits 4809 4806 -3
- Misses 12144 12146 +2
- Partials 687 688 +1
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
lunny
added
the
pr/breaking
appleboy
reviewed
Nov 1, 2017
routers/api/v1/utils/hook.go
Outdated
| @@ -69,7 +69,7 @@ func AddOrgHook(ctx *context.APIContext, form *api.CreateHookOption) { | |||
| org := ctx.Org.Organization | |||
| hook, ok := addHook(ctx, form, org.ID, 0) | |||
| if ok { | |||
| ctx.JSON(200, convert.ToHook(org.HomeLink(), hook)) | |||
| ctx.JSON(201, convert.ToHook(org.HomeLink(), hook)) | |||
There was a problem hiding this comment.
maybe change to http.StatusCreated for readable.
There was a problem hiding this comment.
done? I don't see any changes for this.
There was a problem hiding this comment.
Oh, the changes were lost when I rebased. I've readded the lost changes
|
@ethantkoenig please also regenerate swagger.json file |
|
@lafriks Done |
ethantkoenig
force-pushed
the
fix/hook_api
branch
from
71642b6
to
11c8ea9
Compare
|
Rebased to rerun CI |
|
@ethantkoenig fmt error |
ethantkoenig
force-pushed
the
fix/hook_api
branch
from
11c8ea9
to
2719d4e
Compare
|
Need to verify that Jenkins & Drone plugins are not affected by this |
ethantkoenig
force-pushed
the
fix/hook_api
branch
from
2719d4e
to
f9df529
Compare
|
Thanks than LGTM |
tboerger
added
lgtm/need 1
appleboy
approved these changes
Nov 20, 2017
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return 201, instead of 200, when creating a hook via the API; this is in compliance with the Github API, and more generally the semantics of HTTP status codes. Affects the following routes:
POST /:owner/:repo/hooksPOST /orgs/:org/hooks