Fix: Hide divider when labels are hidden #27747
Open
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
puni9869
changed the title
|
This is ready for review |
delvh
reviewed
Oct 26, 2023
| @@ -206,6 +206,8 @@ function initArchivedLabelFilter() { | |||
| for (const label of archivedLabels) { | |||
| const id = label.getAttribute('data-label-id'); | |||
| toggleElem(label, archivedLabelEl.checked || selectedLabels.includes(id)); | |||
| // also toggle the divider | |||
| toggleElem($(label).next('.exclusive-scope'), archivedLabelEl.checked || selectedLabels.includes(id)); | |||
There was a problem hiding this comment.
- There is not necessarily a divider
- I think the condition is wrong. It works in the situation you've tested, but I'm fairly certain that in more complex situations it will hide the divider even though it shouldn't.
delvh
reviewed
Oct 26, 2023
| @@ -691,5 +691,7 @@ export function initArchivedLabelHandler() { | |||
| if (!document.querySelector('.archived-label-hint')) return; | |||
| for (const label of document.querySelectorAll('[data-is-archived]')) { | |||
| toggleElem(label, label.classList.contains('checked')); | |||
| // also toggle the divider | |||
| toggleElem($(label).next('.exclusive-scope'), label.classList.contains('checked')); | |||
There was a problem hiding this comment.
Will test it rigorously.
There was a problem hiding this comment.
The usecase I imagine to be faulty is two (or more) labels in scope, one archived, the other not.
There was a problem hiding this comment.
The same I was thinking, with org labels as well.
There was a problem hiding this comment.
4805034b-ceec-46cd-8631-fca2b25a2d38.mp4
This is the current condition with org and repo labels with all possible usecase,
One is failing, when we have archived label with scoped and normal label with archived marked.
github-actions
bot
added
modifies/templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title
regression #27466
After changes:
