Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix emojify image URL #2769

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Fix emojify image URL #2769

merged 1 commit into from
Oct 23, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Oct 23, 2017

Fixes #2759

@lafriks lafriks added this to the 1.3.0 milestone Oct 23, 2017
@codecov-io
Copy link

Codecov Report

Merging #2769 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2769   +/-   ##
======================================
  Coverage    26.9%   26.9%           
======================================
  Files          88      88           
  Lines       17289   17289           
======================================
  Hits         4652    4652           
  Misses      11958   11958           
  Partials      679     679

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a257f88...8f4b888. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2017
@lunny
Copy link
Member

lunny commented Oct 23, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 23, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 23, 2017
@appleboy appleboy merged commit e4990ba into go-gitea:master Oct 23, 2017
@lunny
Copy link
Member

lunny commented Oct 23, 2017

back port to 1.2?

@lafriks
Copy link
Member Author

lafriks commented Oct 23, 2017

Yes

@lafriks lafriks deleted the fix/emojify-url branch October 23, 2017 13:49
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Oct 23, 2017
@lafriks
Fix emojify image URL (go-gitea#2769)
5135b68
bkcsoft pushed a commit that referenced this pull request Oct 23, 2017
@lafriks @bkcsoft
Fix emojify image URL (#2769) (#2773)
3c60121
@lafriks lafriks added the backport/done All backports for this PR have been created label Oct 23, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Wrong emojify url
5 participants
@lafriks @codecov-io @lunny @appleboy @tboerger