Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use identicon image for default gravatar. #2767

Merged
merged 2 commits into from
Oct 23, 2017
Merged

Use identicon image for default gravatar. #2767

merged 2 commits into from
Oct 23, 2017

Conversation

harryxu
Copy link
Contributor

@harryxu harryxu commented Oct 23, 2017

Use geometric pattern image as default gravatar. It is easier to distinguish different people.

Before:

After:

@codecov-io
Copy link

Codecov Report

Merging #2767 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2767   +/-   ##
======================================
  Coverage    26.9%   26.9%           
======================================
  Files          88      88           
  Lines       17289   17289           
======================================
  Hits         4652    4652           
  Misses      11958   11958           
  Partials      679     679
Impacted Files Coverage Δ
modules/base/tool.go 73.99% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a257f88...dfef83b. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2017
@lunny lunny added this to the 1.x.x milestone Oct 23, 2017
@lunny lunny added the type/enhancement An improvement of existing functionality label Oct 23, 2017
@lunny
Copy link
Member

lunny commented Oct 23, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 23, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 23, 2017
@appleboy appleboy merged commit 81d1e54 into go-gitea:master Oct 23, 2017
@lunny lunny modified the milestones: 1.x.x, 1.3.0 Oct 23, 2017
@Arnie97 Arnie97 mentioned this pull request Dec 12, 2017
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@harryxu @codecov-io @lunny @appleboy @tboerger