Skip to content

Use minimal required version on CI and remove unnecessary services #27429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Use minimal required version on CI and remove unnecessary services #27429

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
319f09c
Use minial required versio on CI and remove unnecessary services
lunny Oct 4, 2023
0d1dedc
Use mssql 2017 as test database and fix unit test
lunny Oct 4, 2023
cd274db
Merge branch 'main' into lunny/improve_ci
lunny Oct 4, 2023
1e7f530
Add services for test
lunny Oct 4, 2023
7b17662
Merge branch 'main' into lunny/improve_ci
lunny Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use mssql 2017 as test database and fix unit test
  • Loading branch information
@lunny
lunny committed Oct 4, 2023
commit 0d1dedcd5bd7713c9dbc46713c75aa6ed596eba3
19 changes: 18 additions & 1 deletion .github/workflows/pull-db-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,23 @@ jobs:
if: needs.files-changed.outputs.backend == 'true' || needs.files-changed.outputs.actions == 'true'
needs: files-changed
runs-on: ubuntu-latest
services:
redis:
image: redis
options: >- # wait until redis has started
--health-cmd "redis-cli ping"
--health-interval 5s
--health-timeout 3s
--health-retries 10
ports:
- 6379:6379
minio:
image: bitnami/minio:2021.3.17
env:
MINIO_ACCESS_KEY: 123456
MINIO_SECRET_KEY: 12345678
ports:
- "9000:9000"
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v4
Expand Down Expand Up @@ -160,7 +177,7 @@ jobs:
runs-on: ubuntu-latest
services:
mssql:
image: mcr.microsoft.com/mssql/server:2022-latest
image: mcr.microsoft.com/mssql/server:2017-latest
env:
ACCEPT_EULA: Y
MSSQL_PID: Standard
Expand Down